Skip to content

whisper : support GGML_BACKEND_DL #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2025
Merged

whisper : support GGML_BACKEND_DL #2843

merged 3 commits into from
Feb 27, 2025

Conversation

slaren
Copy link
Member

@slaren slaren commented Feb 26, 2025

No description provided.

@slaren
Copy link
Member Author

slaren commented Feb 26, 2025

I didn't notice any issues with the basic functionality, but I am not sure how to test the DTW stuff. The CI failures seem unrelated.

ggerganov
ggerganov approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DTW feature hasn't been exercised for a long time and it seems it broke at some point. The original command that used to work when the feature was added was:

./main -m models/ggml-small.bin -f samples/gb0.wav -dtw small -ojf

#1485 (comment)

Pinging @denersc if they can take a look after merging. But I think it is not super important, since the feature is marked as experimental anyway and I am not sure if it got any significant usage.

@slaren
Copy link
Member Author

slaren commented Feb 26, 2025 •
edited
Loading

I had introduced issues in the DTW code, but it should be fixed now.

The ios-xcode-build CI is failing, it looks like that's because I added the ggml-cpp.h header in whisper.cpp, and it has its own build system, but I don't know how to fix that. It would be easy to remove this header if necessary, it's not used for anything important.

The Ruby CI is also failing, but don't know why or if it is related to the changes here.

@ggerganov
Copy link
Member

I am not sure why the Ruby workflow is failing too, but it's ok to ignore for now. @KitaitiMakoto will probably take a look later.

@slaren slaren merged commit 339a1cb into master Feb 27, 2025
35 of 44 checks passed
@slaren slaren deleted the sl/support-dl-backend branch February 27, 2025 12:35
@slaren slaren mentioned this pull request Feb 28, 2025
Closed
@newfla newfla mentioned this pull request Mar 3, 2025
Closed
joelvaneenwyk pushed a commit to joelvaneenwyk/whisper-cpp that referenced this pull request Mar 3, 2025
@slaren @ggerganov @joelvaneenwyk
whisper : support GGML_BACKEND_DL (ggml-org#2843)
6df5f60 
* whisper : support GGML_BACKEND_DL

* fix DTW crash

* whisper.objc : fix build - add ggml-cpp.h

---------

Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaren @ggerganov