examples : add WHISPER_SDL2 check to deprecation executables #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a check for `WHISPER_SDL2` to the deprecation warning examples. This is to prevent the examples from being built when WHISPER_SDL2 is not enabled. The motivation for this is that currently these deprecation executables are generate and when run they refer the user to examples with other names, for example `whisper-command` but unless they have built with `WHISPER_SDL2` those executable will not be present: ```console $ ls build/bin/ bench command main quantize stream whisper-bench whisper-cli whisper-server $ ./build/bin/command WARNING: The binary 'command' is deprecated. Please use 'whisper-command' instead. See https://github.com/ggerganov/whisper.cpp/tree/master/examples/deprecation-warning/README.md for more information. ```
ggerganov
approved these changes
Mar 20, 2025
buxuku
pushed a commit
to buxuku/whisper.cpp
that referenced
this pull request
Mar 26, 2025
…g#2911) This commit adds a check for `WHISPER_SDL2` to the deprecation warning examples. This is to prevent the examples from being built when WHISPER_SDL2 is not enabled. The motivation for this is that currently these deprecation executables are generate and when run they refer the user to examples with other names, for example `whisper-command` but unless they have built with `WHISPER_SDL2` those executable will not be present: ```console $ ls build/bin/ bench command main quantize stream whisper-bench whisper-cli whisper-server $ ./build/bin/command WARNING: The binary 'command' is deprecated. Please use 'whisper-command' instead. See https://github.com/ggerganov/whisper.cpp/tree/master/examples/deprecation-warning/README.md for more information. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a check for
WHISPER_SDL2to the deprecation warning examples. This is to prevent the examples from being built when WHISPER_SDL2 is not enabled.The motivation for this is that currently these deprecation executables are generate and when run they refer the user to examples with other names, for example
whisper-commandbut unless they have built withWHISPER_SDL2those executable will not be present: