Fix some issues reported by Coverity #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bff014d (builtin rebase: support the `verbose` and `diffstat` options, 2018-09-04), we added a line that wanted to remove the `REBASE_DIFFSTAT` bit from the flags, but it used an incorrect negation. Found by Coverity. Signed-off-by: Johannes Schindelin <[email protected]>
This was overlooked in 53bbcfb (rebase -i: implement the main part of interactive rebase as a builtin, 2018-09-27). Found by Coverity. Signed-off-by: Johannes Schindelin <[email protected]>
In 06f5608 (bisect--helper: `bisect_start` shell function partially in C, 2019-01-02), we introduced a call to `get_oid()` and did not check whether it succeeded before using its output. Signed-off-by: Johannes Schindelin <[email protected]>
Just a little defensive coding. Found by Coverity. Signed-off-by: Johannes Schindelin <[email protected]>
…ation failed Just an obvious fix for an obvious varargs mistake. Signed-off-by: Johannes Schindelin <[email protected]>
We specifically reduce the number of parallel links for MSVC, as RAM usage is an issue with MSVC's parallel mode, manifested in the symptom: fatal error LNK1318: Unexpected PDB error; OK (0) '' Signed-off-by: Johannes Schindelin <[email protected]>
We do not actually need to test for `state != NULL`, as `state->delayed_checkout` had already been accessed before this. Signed-off-by: Johannes Schindelin <[email protected]>
We do fall back to not enabling the FSCache when we're out of Thread-Local indexes, but we failed to unlock the mutex. Signed-off-by: Johannes Schindelin <[email protected]>
The return value of that function is not actually we are currently able to translate to an `errno`-style value easily. So let's just not. Signed-off-by: Johannes Schindelin <[email protected]>
Coverity pointed out a couple of bugs, and here are fixes for some of them. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
address-coverity-report
branch
from
32a8612 to
32b5d74
Compare
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2019
Fix some issues reported by Coverity
dscho
added a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
dscho
added a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
dscho
added a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Fix some issues reported by Coverity
dscho
added a commit
that referenced
this pull request
May 13, 2019
Fix some issues reported by Coverity
dscho
added a commit
that referenced
this pull request
May 13, 2019
Fix some issues reported by Coverity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only swept the report broadly, looking for some obvious things we might want to fix.