first trial of git2-to-gix
#4509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Byron
force-pushed
the
git2-to-gix
branch
2 times, most recently
from
ba30252 to
e90e417
Compare
Also, remove the pager as there seems to be no need for it just yet, one day it can probably be added when configured neatly.
This allows actual GitButler setups and more complex tests, which are also added here.
This also needs the ability to create commits. Also experiment with `async` tauri commands, but without actually making them `async` - nothing actually is so why pretend? Further, assure we get the correct author and committer which helps it pick up the overridden author information when creating a commit.
Sounds good, just note that the link is from the Tauri 2 docs (we are still on v1). I imagine that async behaviour is the same in v1 too. |
krlvi
approved these changes
Jul 28, 2024
|
Yes, I'd think that too, otherwise it's more like a bug to fix. Nonetheless, I will try the non-async version to assure it still feels snappy. |
This was referenced Jul 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at
BranchListingonly, try to convert the usage ofgit2related to branches to usinggixinstead.Do so without having while assuring that the output stays the same.
Follow-up of #4473.
Tasks
BranchListingfunction to see the status quo (minimal)Follow-Up
async? Sweeping changes.gix#4543identitytypesafe. #4590git2togix.gix#4632gixfor branch normalization #4665gix: 2.6x faster! #4670Review Notes
tauri::command(async)is entirely independent ofasync fn, which means there is no need to pretend anymore. It seems no matter what,runtime::spawnis used, so it should be fine. I'd rather do that instead of having fakeasyncfunctions, astaurithen at least knows these functions block so they should definitely be spawned asspawn_blocking(). Not lying about this makes it easy to call these functions from the CLI