Skip to content

Go: Support GOPROXY via the Dependabot proxy #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbg
Copy link
Member

@mbg mbg commented Mar 31, 2025

We now support the goproxy_server registry type for Go. This PR updates the LANGUAGE_TO_REGISTRY_TYPE record so that we don't abort getting the credentials for corresponding configurations.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@mbg mbg force-pushed the mbg/private-registry/goproxy branch from 5e994c3 to 6ad5d99 Compare April 25, 2025 15:56
@mbg mbg marked this pull request as ready for review April 25, 2025 15:58
@Copilot Copilot AI review requested due to automatic review settings April 25, 2025 15:58
@mbg mbg requested a review from a team as a code owner April 25, 2025 15:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mapping for the Go language so that Dependabot now correctly uses the "goproxy_server" registry type instead of an empty string.

  • Update in src/start-proxy.ts to add the correct registry type for Go
  • Update in lib/start-proxy.js to reflect the same change for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/start-proxy.ts Added "go: 'goproxy_server'" and removed the duplicated empty entry
lib/start-proxy.js Updated the Go registry type to "goproxy_server" and removed the empty entry

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we have an integration test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants