Statements1 #141

s-samadi · 2022-11-19T01:28:52Z

Description

Moved the following queries to common library for reuse in C queries:

A5-0-2
M6-4-2
M6-4-3
M6-4-4
M6-6-2

I added any change notes for query message formatting.

Added the following queries as a part of Statements package:

FLP30-C
Rule 14.2
Rule 14.3
Rule 14.4
Rule 15.2
Rule 15.3
Rule 15.4
Rule 15.5
Rule 15.6
Rule 15.7
Rule 16.1
Rule 16.2
Rule 16.3
Rule 16.4
Rule 16.5
Rule 16.6
Rule 16.7
Rule 17.2
Rule 17.4

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- FLP30-C
- Rule 14.2
- Rule 14.3
- Rule 14.4
- Rule 15.2
- Rule 15.3
- Rule 15.4
- Rule 15.5
- Rule 15.6
- Rule 15.7
- Rule 16.1
- Rule 16.2
- Rule 16.3
- Rule 16.4
- Rule 16.5
- Rule 16.6
- Rule 16.7
- Rule 17.2
- Rule 17.4
Queries have been modified for the following rules:
- A5-0-2
- M6-4-2
- M6-4-3
- M6-4-4
- M6-6-2

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

…to common folder

rvermeulen

First pass where I looked at 16-2, 16-3, and 16-4.

cpp/common/src/codingstandards/cpp/rules/nestedlabelinswitch/NestedLabelInSwitch.qll

c/misra/src/rules/RULE-16-2/NestSwitchLabelInSwitchStatement.ql

c/misra/src/rules/RULE-16-3/BreakShallTerminateSwitchClause.ql

c/misra/src/rules/RULE-16-4/EverySwitchShallHaveDefaultLabel.ql

c/misra/src/rules/RULE-16-5/DefaultNotFirstOrLastOfSwitch.ql

…estedLabelInSwitch.qll Co-authored-by: Remco Vermeulen <[email protected]>

github-actions · 2023-02-21T01:28:39Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T02:16:17Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T03:22:37Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T03:24:03Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T04:15:48Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T04:20:17Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-21T20:33:46Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-26T22:06:14Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T22:06:19Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T22:10:03Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements4
QUERY                : FloatingPointLoopCounters
RULE                 : FLP30-C

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements2
QUERY                : GotoLabelLocationCondition
RULE                 : RULE-15-2

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : IfElseEndCondition
RULE                 : RULE-15-7

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements1
QUERY                : NestSwitchLabelInSwitchStatement
RULE                 : RULE-16-2

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : SwitchCaseStartCondition
RULE                 : RULE-16-1

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : SwitchStmtNotWellFormed
RULE                 : RULE-16-1

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements4
QUERY                : ForLoopNotWellFormed
RULE                 : RULE-14-2

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements5
QUERY                : ControllingExprInvariant
RULE                 : RULE-14-3

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements4
QUERY                : NonBooleanIfCondition
RULE                 : RULE-14-4

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements4
QUERY                : NonBooleanIterationCondition
RULE                 : RULE-14-4

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements6
QUERY                : GotoStatementUsed
RULE                 : RULE-15-1

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements2
QUERY                : GotoLabelBlockCondition
RULE                 : RULE-15-3

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements2
QUERY                : LoopIterationCondition
RULE                 : RULE-15-4

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements5
QUERY                : FunctionReturnCondition
RULE                 : RULE-15-5

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : SwitchCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : SelectionCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : LoopCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements1
QUERY                : BreakShallTerminateSwitchClause
RULE                 : RULE-16-3

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements1
QUERY                : EverySwitchShallHaveDefaultLabel
RULE                 : RULE-16-4

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements1
QUERY                : DefaultNotFirstOrLastOfSwitch
RULE                 : RULE-16-5

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements2
QUERY                : SwitchClauseNumberCondition
RULE                 : RULE-16-6

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements2
QUERY                : SwitchExpressionBoolCondition
RULE                 : RULE-16-7

TEST_PASS            : True
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Statements3
QUERY                : RecursiveFunctionCondition
RULE                 : RULE-17-2

jsinglet · 2023-03-26T22:11:51Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : FLP30-C
QUERY                : FloatingPointLoopCounters
PACKAGE              : Statements4
SUITE                : CERT-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-2
QUERY                : GotoLabelLocationCondition
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-7
QUERY                : IfElseEndCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-2
QUERY                : NestSwitchLabelInSwitchStatement
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-1
QUERY                : SwitchCaseStartCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-1
QUERY                : SwitchStmtNotWellFormed
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-14-2
QUERY                : ForLoopNotWellFormed
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-14-3
QUERY                : ControllingExprInvariant
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-14-4
QUERY                : NonBooleanIfCondition
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-14-4
QUERY                : NonBooleanIterationCondition
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-1
QUERY                : GotoStatementUsed
PACKAGE              : Statements6
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-3
QUERY                : GotoLabelBlockCondition
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-4
QUERY                : LoopIterationCondition
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-5
QUERY                : FunctionReturnCondition
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-6
QUERY                : SwitchCompoundCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-6
QUERY                : LoopCompoundCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-15-6
QUERY                : SelectionCompoundCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-3
QUERY                : BreakShallTerminateSwitchClause
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-4
QUERY                : EverySwitchShallHaveDefaultLabel
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-5
QUERY                : DefaultNotFirstOrLastOfSwitch
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-6
QUERY                : SwitchClauseNumberCondition
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-16-7
QUERY                : SwitchExpressionBoolCondition
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
RULE                 : RULE-17-2
QUERY                : RecursiveFunctionCondition
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

jsinglet · 2023-03-26T22:18:17Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


RULE                 : FLP30-C
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : FloatingPointLoopCounters
PACKAGE              : Statements4

RULE                 : RULE-15-2
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : GotoLabelLocationCondition
PACKAGE              : Statements2

RULE                 : RULE-15-7
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : IfElseEndCondition
PACKAGE              : Statements3

RULE                 : RULE-16-2
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : NestSwitchLabelInSwitchStatement
PACKAGE              : Statements1

RULE                 : RULE-16-1
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SwitchCaseStartCondition
PACKAGE              : Statements3

RULE                 : RULE-16-1
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SwitchStmtNotWellFormed
PACKAGE              : Statements3

RULE                 : RULE-14-2
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : ForLoopNotWellFormed
PACKAGE              : Statements4

RULE                 : RULE-14-3
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : ControllingExprInvariant
PACKAGE              : Statements5

RULE                 : RULE-14-4
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : NonBooleanIfCondition
PACKAGE              : Statements4

RULE                 : RULE-14-4
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : NonBooleanIterationCondition
PACKAGE              : Statements4

RULE                 : RULE-15-1
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : GotoStatementUsed
PACKAGE              : Statements6

RULE                 : RULE-15-3
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : GotoLabelBlockCondition
PACKAGE              : Statements2

RULE                 : RULE-15-4
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : LoopIterationCondition
PACKAGE              : Statements2

RULE                 : RULE-15-5
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : FunctionReturnCondition
PACKAGE              : Statements5

RULE                 : RULE-15-6
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SelectionCompoundCondition
PACKAGE              : Statements3

RULE                 : RULE-15-6
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : LoopCompoundCondition
PACKAGE              : Statements3

RULE                 : RULE-15-6
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SwitchCompoundCondition
PACKAGE              : Statements3

RULE                 : RULE-16-3
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : BreakShallTerminateSwitchClause
PACKAGE              : Statements1

RULE                 : RULE-16-4
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : EverySwitchShallHaveDefaultLabel
PACKAGE              : Statements1

RULE                 : RULE-16-5
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : DefaultNotFirstOrLastOfSwitch
PACKAGE              : Statements1

RULE                 : RULE-16-6
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SwitchClauseNumberCondition
PACKAGE              : Statements2

RULE                 : RULE-16-7
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : SwitchExpressionBoolCondition
PACKAGE              : Statements2

RULE                 : RULE-17-2
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
QUERY                : RecursiveFunctionCondition
PACKAGE              : Statements3

jsinglet · 2023-03-26T22:18:30Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-26T22:23:47Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-26T22:30:23Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T22:32:47Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T22:32:51Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T22:37:50Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
RULE                 : FLP30-C
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements4
SUITE                : CERT-C
COMPILE_ERROR_OUTPUT : 
QUERY                : FloatingPointLoopCounters

TEST_DIFFERENCE      : 
RULE                 : RULE-15-2
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : GotoLabelLocationCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-7
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : IfElseEndCondition

TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,3 +1,3 @@
                       -| test.c:9:5:9:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:36:5:36:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:76:5:76:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:9:5:9:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:36:5:36:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:76:5:76:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       [1/1 comp 6.6s eval 261ms] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/common/test/rules/nestedlabelinswitch/NestedLabelInSwitch.ql
                       
RULE                 : RULE-16-2
TEST_PASS            : False
COMPILE_PASS         : True
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : NestSwitchLabelInSwitchStatement

TEST_DIFFERENCE      : 
RULE                 : RULE-16-1
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SwitchCaseStartCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-16-1
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SwitchStmtNotWellFormed

TEST_DIFFERENCE      : 
RULE                 : RULE-14-2
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : ForLoopNotWellFormed

TEST_DIFFERENCE      : 
RULE                 : RULE-14-3
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : ControllingExprInvariant

TEST_DIFFERENCE      : 
RULE                 : RULE-14-4
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : NonBooleanIfCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-14-4
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : NonBooleanIterationCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-1
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements6
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : GotoStatementUsed

TEST_DIFFERENCE      : 
RULE                 : RULE-15-3
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : GotoLabelBlockCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-4
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : LoopIterationCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-5
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : FunctionReturnCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-6
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SwitchCompoundCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-6
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SelectionCompoundCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-15-6
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : LoopCompoundCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-16-3
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : BreakShallTerminateSwitchClause

TEST_DIFFERENCE      : 
RULE                 : RULE-16-4
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : EverySwitchShallHaveDefaultLabel

TEST_DIFFERENCE      : 
RULE                 : RULE-16-5
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : DefaultNotFirstOrLastOfSwitch

TEST_DIFFERENCE      : 
RULE                 : RULE-16-6
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SwitchClauseNumberCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-16-7
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : SwitchExpressionBoolCondition

TEST_DIFFERENCE      : 
RULE                 : RULE-17-2
TEST_PASS            : True
COMPILE_PASS         : True
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
COMPILE_ERROR_OUTPUT : 
QUERY                : RecursiveFunctionCondition

jsinglet · 2023-03-26T22:38:04Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : CERT-C
QUERY                : FloatingPointLoopCounters
RULE                 : FLP30-C
PACKAGE              : Statements4

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : GotoLabelLocationCondition
RULE                 : RULE-15-2
PACKAGE              : Statements2

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : IfElseEndCondition
RULE                 : RULE-15-7
PACKAGE              : Statements3

TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,3 +1,3 @@
                       -| test.c:9:5:9:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:36:5:36:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:76:5:76:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:9:5:9:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:36:5:36:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:76:5:76:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       [1/1 comp 6.7s eval 263ms] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/common/test/rules/nestedlabelinswitch/NestedLabelInSwitch.ql
                       
TEST_PASS            : False
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : NestSwitchLabelInSwitchStatement
RULE                 : RULE-16-2
PACKAGE              : Statements1

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SwitchCaseStartCondition
RULE                 : RULE-16-1
PACKAGE              : Statements3

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SwitchStmtNotWellFormed
RULE                 : RULE-16-1
PACKAGE              : Statements3

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : ForLoopNotWellFormed
RULE                 : RULE-14-2
PACKAGE              : Statements4

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : ControllingExprInvariant
RULE                 : RULE-14-3
PACKAGE              : Statements5

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : NonBooleanIfCondition
RULE                 : RULE-14-4
PACKAGE              : Statements4

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : NonBooleanIterationCondition
RULE                 : RULE-14-4
PACKAGE              : Statements4

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : GotoStatementUsed
RULE                 : RULE-15-1
PACKAGE              : Statements6

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : GotoLabelBlockCondition
RULE                 : RULE-15-3
PACKAGE              : Statements2

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : LoopIterationCondition
RULE                 : RULE-15-4
PACKAGE              : Statements2

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : FunctionReturnCondition
RULE                 : RULE-15-5
PACKAGE              : Statements5

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SwitchCompoundCondition
RULE                 : RULE-15-6
PACKAGE              : Statements3

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : LoopCompoundCondition
RULE                 : RULE-15-6
PACKAGE              : Statements3

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SelectionCompoundCondition
RULE                 : RULE-15-6
PACKAGE              : Statements3

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : BreakShallTerminateSwitchClause
RULE                 : RULE-16-3
PACKAGE              : Statements1

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : EverySwitchShallHaveDefaultLabel
RULE                 : RULE-16-4
PACKAGE              : Statements1

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : DefaultNotFirstOrLastOfSwitch
RULE                 : RULE-16-5
PACKAGE              : Statements1

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SwitchClauseNumberCondition
RULE                 : RULE-16-6
PACKAGE              : Statements2

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : SwitchExpressionBoolCondition
RULE                 : RULE-16-7
PACKAGE              : Statements2

TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : MISRA-C-2012
QUERY                : RecursiveFunctionCondition
RULE                 : RULE-17-2
PACKAGE              : Statements3

jsinglet · 2023-03-26T22:45:29Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements4
SUITE                : CERT-C
QUERY                : FloatingPointLoopCounters
RULE                 : FLP30-C

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
QUERY                : GotoLabelLocationCondition
RULE                 : RULE-15-2

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : IfElseEndCondition
RULE                 : RULE-15-7

TEST_PASS            : False
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,3 +1,3 @@
                       -| test.c:9:5:9:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:36:5:36:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       -| test.c:76:5:76:11 | case ...: | The switch $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:9:5:9:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:9:5:9:11 | case ...: | case ...: | test.c:6:3:17:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:36:5:36:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:36:5:36:11 | case ...: | case ...: | test.c:23:3:43:3 | switch (...) ...  | switch (...) ...  |
                       +| test.c:76:5:76:11 | case ...: | The case $@ does not appear at the outermost level of the compound statement forming the body of the $@ statement. | test.c:76:5:76:11 | case ...: | case ...: | test.c:73:3:79:3 | switch (...) ...  | switch (...) ...  |
                       [1/1 comp 7.4s eval 283ms] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/common/test/rules/nestedlabelinswitch/NestedLabelInSwitch.ql
                       
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
QUERY                : NestSwitchLabelInSwitchStatement
RULE                 : RULE-16-2

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : SwitchCaseStartCondition
RULE                 : RULE-16-1

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : SwitchStmtNotWellFormed
RULE                 : RULE-16-1

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
QUERY                : ForLoopNotWellFormed
RULE                 : RULE-14-2

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
QUERY                : ControllingExprInvariant
RULE                 : RULE-14-3

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
QUERY                : NonBooleanIfCondition
RULE                 : RULE-14-4

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements4
SUITE                : MISRA-C-2012
QUERY                : NonBooleanIterationCondition
RULE                 : RULE-14-4

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements6
SUITE                : MISRA-C-2012
QUERY                : GotoStatementUsed
RULE                 : RULE-15-1

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
QUERY                : GotoLabelBlockCondition
RULE                 : RULE-15-3

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
QUERY                : LoopIterationCondition
RULE                 : RULE-15-4

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements5
SUITE                : MISRA-C-2012
QUERY                : FunctionReturnCondition
RULE                 : RULE-15-5

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : LoopCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : SelectionCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : SwitchCompoundCondition
RULE                 : RULE-15-6

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
QUERY                : BreakShallTerminateSwitchClause
RULE                 : RULE-16-3

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
QUERY                : EverySwitchShallHaveDefaultLabel
RULE                 : RULE-16-4

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements1
SUITE                : MISRA-C-2012
QUERY                : DefaultNotFirstOrLastOfSwitch
RULE                 : RULE-16-5

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
QUERY                : SwitchClauseNumberCondition
RULE                 : RULE-16-6

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements2
SUITE                : MISRA-C-2012
QUERY                : SwitchExpressionBoolCondition
RULE                 : RULE-16-7

TEST_PASS            : True
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
PACKAGE              : Statements3
SUITE                : MISRA-C-2012
QUERY                : RecursiveFunctionCondition
RULE                 : RULE-17-2

jsinglet · 2023-03-26T22:45:49Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-26T23:51:01Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-26T23:53:45Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-26T23:54:26Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-26T23:57:49Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-26T23:59:47Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-27T00:04:57Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
PACKAGE              : Statements4
QUERY                : FloatingPointLoopCounters
COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
RULE                 : FLP30-C
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements2
QUERY                : GotoLabelLocationCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-2
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : IfElseEndCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-7
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements1
QUERY                : NestSwitchLabelInSwitchStatement
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-2
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : SwitchCaseStartCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-1
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : SwitchStmtNotWellFormed
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-1
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements4
QUERY                : ForLoopNotWellFormed
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-2
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements5
QUERY                : ControllingExprInvariant
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-3
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements4
QUERY                : NonBooleanIfCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-4
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements4
QUERY                : NonBooleanIterationCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-4
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements6
QUERY                : GotoStatementUsed
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-1
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements2
QUERY                : GotoLabelBlockCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-3
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements2
QUERY                : LoopIterationCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-4
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements5
QUERY                : FunctionReturnCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-5
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : SelectionCompoundCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : LoopCompoundCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : SwitchCompoundCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements1
QUERY                : BreakShallTerminateSwitchClause
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-3
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements1
QUERY                : EverySwitchShallHaveDefaultLabel
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-4
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements1
QUERY                : DefaultNotFirstOrLastOfSwitch
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-5
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements2
QUERY                : SwitchClauseNumberCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-6
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements2
QUERY                : SwitchExpressionBoolCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-7
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

TEST_PASS            : True
PACKAGE              : Statements3
QUERY                : RecursiveFunctionCondition
COMPILE_ERROR_OUTPUT : 
SUITE                : MISRA-C-2012
RULE                 : RULE-17-2
TEST_DIFFERENCE      : 
COMPILE_PASS         : True

jsinglet · 2023-03-27T00:05:02Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : Statements4
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : CERT-C
RULE                 : FLP30-C
TEST_PASS            : True
QUERY                : FloatingPointLoopCounters

PACKAGE              : Statements2
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-2
TEST_PASS            : True
QUERY                : GotoLabelLocationCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-7
TEST_PASS            : True
QUERY                : IfElseEndCondition

PACKAGE              : Statements1
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-2
TEST_PASS            : True
QUERY                : NestSwitchLabelInSwitchStatement

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-1
TEST_PASS            : True
QUERY                : SwitchCaseStartCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-1
TEST_PASS            : True
QUERY                : SwitchStmtNotWellFormed

PACKAGE              : Statements4
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-2
TEST_PASS            : True
QUERY                : ForLoopNotWellFormed

PACKAGE              : Statements5
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-3
TEST_PASS            : True
QUERY                : ControllingExprInvariant

PACKAGE              : Statements4
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-4
TEST_PASS            : True
QUERY                : NonBooleanIfCondition

PACKAGE              : Statements4
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-14-4
TEST_PASS            : True
QUERY                : NonBooleanIterationCondition

PACKAGE              : Statements6
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-1
TEST_PASS            : True
QUERY                : GotoStatementUsed

PACKAGE              : Statements2
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-3
TEST_PASS            : True
QUERY                : GotoLabelBlockCondition

PACKAGE              : Statements2
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-4
TEST_PASS            : True
QUERY                : LoopIterationCondition

PACKAGE              : Statements5
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-5
TEST_PASS            : True
QUERY                : FunctionReturnCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_PASS            : True
QUERY                : SelectionCompoundCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_PASS            : True
QUERY                : LoopCompoundCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-15-6
TEST_PASS            : True
QUERY                : SwitchCompoundCondition

PACKAGE              : Statements1
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-3
TEST_PASS            : True
QUERY                : BreakShallTerminateSwitchClause

PACKAGE              : Statements1
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-4
TEST_PASS            : True
QUERY                : EverySwitchShallHaveDefaultLabel

PACKAGE              : Statements1
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-5
TEST_PASS            : True
QUERY                : DefaultNotFirstOrLastOfSwitch

PACKAGE              : Statements2
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-6
TEST_PASS            : True
QUERY                : SwitchClauseNumberCondition

PACKAGE              : Statements2
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-16-7
TEST_PASS            : True
QUERY                : SwitchExpressionBoolCondition

PACKAGE              : Statements3
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
SUITE                : MISRA-C-2012
RULE                 : RULE-17-2
TEST_PASS            : True
QUERY                : RecursiveFunctionCondition

jsinglet · 2023-03-27T00:05:15Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

s-samadi added 7 commits November 18, 2022 10:56

moved M-4-4 to common lib

7589868

added Statements1 package and generated files

32391bb

added RULE-16-2

e98102f

updated rules.csv for Statements1 package and refactored rule 16-2 in…

9e68f0b

…to common folder

Added rules and tests for RULE-16-3, RULE-16-4, RULE-16-5

c90f566

Merge branch 'main' into statements1

c015254

Fixed formatting issue for test RULE-16-3

5745732

s-samadi requested a review from rvermeulen November 21, 2022 10:15

s-samadi marked this pull request as ready for review November 21, 2022 10:15

rvermeulen requested changes Jan 13, 2023

View reviewed changes

rvermeulen reviewed Feb 4, 2023

View reviewed changes

c/misra/src/rules/RULE-16-5/DefaultNotFirstOrLastOfSwitch.ql Outdated Show resolved Hide resolved

rvermeulen reviewed Feb 4, 2023

View reviewed changes

c/misra/src/rules/RULE-16-5/DefaultNotFirstOrLastOfSwitch.ql Outdated Show resolved Hide resolved

s-samadi and others added 3 commits February 21, 2023 12:09

Update cpp/common/src/codingstandards/cpp/rules/nestedlabelinswitch/N…

321aee1

…estedLabelInSwitch.qll Co-authored-by: Remco Vermeulen <[email protected]>

Update cpp/common/src/codingstandards/cpp/rules/nestedlabelinswitch/N…

c9a7b57

…estedLabelInSwitch.qll Co-authored-by: Remco Vermeulen <[email protected]>

merged conflicts

c8b550b

s-samadi marked this pull request as draft February 21, 2023 01:31

updated rule metadata based on PR feedback

21a4432

Added test case to 16-3 for non last default labels

48175e7

updated metadata for 16-3 based on PR feedback

0e68e41

updated metadata for 16-5

6b575f4

removed full stop from name property of 16-2

9f6b224

WIP

80b891f

Implementation for RULE-15-2

c76909c

lcartey added 2 commits March 26, 2023 23:20

Rule 16.4: Consider nested blocks.

250e06f

Statements: Improve metadata.

d8b3fac

lcartey enabled auto-merge March 26, 2023 22:23

NestedLabelInSwitch: Update expected after alert msg change

d5750b0

lcartey added this pull request to the merge queue Mar 27, 2023

Merged via the queue into main with commit 4a2f35f Mar 27, 2023

lcartey deleted the statements1 branch March 27, 2023 01:32

Statements1 #141

Statements1 #141

Uh oh!

Conversation

s-samadi commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

rvermeulen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

github-actions bot commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

github-actions bot commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

Uh oh!

jsinglet commented Mar 26, 2023

s-samadi commented Nov 19, 2022 •

edited

Loading