Skip to content

Java: Documentation fixes in the "Permissive dot regex" experimental query #10249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

atorralba
Copy link
Contributor

Fixes some docs in the experimental query "Permissive dot regex" merged in #9873.

@atorralba atorralba requested a review from a team as a code owner September 1, 2022 07:19
@atorralba atorralba force-pushed the atorralba/regex-dot-bypass-docs branch from 6bae9d3 to 2541231 Compare September 1, 2022 07:20
@atorralba atorralba force-pushed the atorralba/regex-dot-bypass-docs branch from 2541231 to 04c230b Compare September 1, 2022 07:57
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth spending too much time on the docs of an experimental query unless we're planning to promote it soon. Fixed two things, otherwise LGTM at a quick glance.

@atorralba
Copy link
Contributor Author

Agree, I just did this because I recently merged the experimental query but forgot to add these changes as suggestions, so I created a new PR.

Thanks for the review and fixes!

@atorralba atorralba merged commit c0dd9dd into github:main Sep 6, 2022
@atorralba atorralba deleted the atorralba/regex-dot-bypass-docs branch September 6, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants