Skip to content

Java: Add new AlarmManager sinks to Use of implicit PendingIntents #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

atorralba
Copy link
Contributor

This PR adds new sinks related to AlarmManager to the query Use of implicit PendingIntents.

This adds coverage for CVE-2021-0599.

@atorralba atorralba requested a review from a team as a code owner September 1, 2022 07:49
@github-actions github-actions bot added the Java label Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,52,424,108,,,3,67,,,
+    Android,``android.*``,52,424,116,,,3,67,,,
-    Totals,,217,6442,1476,119,6,10,107,33,1,84
+    Totals,,217,6442,1484,119,6,10,107,33,1,84
  • Changes to framework-coverage-java.csv:
- android.app,16,,103,,,,,,7,,,,,,,,,9,,,,,,,,,,,,,,,,,,,18,85
+ android.app,24,,103,,,,,,7,,,,,,,,,17,,,,,,,,,,,,,,,,,,,18,85

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Android,``android.*``,52,424,108,,,3,67,,,
+    Android,``android.*``,52,424,116,,,3,67,,,
-    Totals,,217,6442,1476,119,6,10,107,33,1,84
+    Totals,,217,6442,1484,119,6,10,107,33,1,84
  • Changes to framework-coverage-java.csv:
- android.app,16,,103,,,,,,7,,,,,,,,,9,,,,,,,,,,,,,,,,,,,18,85
+ android.app,24,,103,,,,,,7,,,,,,,,,17,,,,,,,,,,,,,,,,,,,18,85

@atorralba atorralba merged commit b94e0d3 into github:main Sep 6, 2022
@atorralba atorralba deleted the atorralba/implicit-pendingintent-sinks branch September 6, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants