-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PY: change alert messages of path queries to use the same template #10252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,5 +22,5 @@ import DataFlow::PathGraph | |
|
||
from Configuration config, DataFlow::PathNode source, DataFlow::PathNode sink | ||
where config.hasFlowPath(source, sink) | ||
select sink.getNode(), source, sink, "$@ flows to here and is used in a path.", source.getNode(), | ||
"User-provided value" | ||
select sink.getNode(), source, sink, "This path depends on $@.", source.getNode(), | ||
"a user-provided value" | ||
Comment on lines
+25
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm rather rusty on how these select statements look in results. Am I right to think that this is shown as:
If so, this looks good to me 👍🏻 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, that's right! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one sounds a bit strange to me ("'value modification'? What's that?"), but I couldn't come up with a better phrasing.
Also, "depends on a default value" seems too weak of a statement to me. It not only depends on a default value, it actively mutates said default value.
Edit: Perhaps "
This expression mutates a default value.
" would be better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
s/mutates/modifies/
might be even better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's a
DataFlow::Configuration
and not aTaintTracking::Configuration
, so depends is too weak a statement."This expression mutates a default value" sounds good to me 👍