-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ensure consistent casing of names #10312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
c6c5f67
to
26d8553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently looked at changing the casing to Http
in Concepts.qll, but ran into the same problems as you have with the Http
modules in Django/Stdlib and so on. I guess renaming them is fine, since they're inside Private...
modules that are intended for only internal use.
I was a little surprised about the naming StdHttp
, and I think it would more consistent to use StdlibHttp
.
Co-authored-by: Rasmus Wriedt Larsen <[email protected]>
c9ea10b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 16 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python still 👍 (sorry for the late review, thought this might have been waiting for someone else)
I recently added a QL-for-QL query to detect when two names only differ in casing inside a single language.
E.g. Python used both
Multidict
andMultiDict
.This can cause confusion, so I'm fixing it.
I did the following renamings:
SSA
->Ssa
LDAP
->Ldap
HTTP
->Http
Multidict
->MultiDict
URL
->Url
Newobj
->NewObj
Rethrow
->ReThrow
In Python I had to do a few renamings in order to avoid naming conflicts.
I skipped
HTML
andAPI
, so those are still used both asHTML/Html
andAPI/Api
.