ensure consistent casing of names #10312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/BoundSpecific.qll
Fixed
Show fixed
Hide fixed
erik-krogh
force-pushed
the
fix-caseDiff
branch
from
c6c5f67 to
26d8553
Compare
RasmusWL
requested changes
Sep 9, 2022
There was a problem hiding this comment.
I recently looked at changing the casing to Http in Concepts.qll, but ran into the same problems as you have with the Http modules in Django/Stdlib and so on. I guess renaming them is fine, since they're inside Private... modules that are intended for only internal use.
I was a little surprised about the naming StdHttp, and I think it would more consistent to use StdlibHttp.
Co-authored-by: Rasmus Wriedt Larsen <[email protected]>
erik-krogh
dismissed stale reviews from geoffw0, michaelnebel, and tausbn
via
c9ea10b
MathiasVP
previously approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Found 16 potential problems in the proposed changes. Check the Files changed tab for more details.
MathiasVP
previously approved these changes
Sep 12, 2022
aibaars
previously approved these changes
Sep 12, 2022
RasmusWL
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently added a QL-for-QL query to detect when two names only differ in casing inside a single language.
E.g. Python used both
MultidictandMultiDict.This can cause confusion, so I'm fixing it.
I did the following renamings:
SSA->SsaLDAP->LdapHTTP->HttpMultidict->MultiDictURL->UrlNewobj->NewObjRethrow->ReThrowIn Python I had to do a few renamings in order to avoid naming conflicts.
I skipped
HTMLandAPI, so those are still used both asHTML/HtmlandAPI/Api.