Python: Revert changes to sensitive data query alert messages #10314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partly reverts the changes from github#10252 Although consistency is nice, the new messages didn't sound as natural. New alert message would read > Insecure hashing algorithm (md5) depends on sensitive data (password). (...) I'm not sure what it means that a hashing algorithm depends on data. So for me, the original text below is much easier to understand. > Sensitive data (password) is used in a hashing algorithm (md5) that is insecure (...) Same goes for the other sensitive data queries.
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Sep 6, 2022
tausbn
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly reverts the changes from #10252
Although consistency is nice, the new messages didn't sound as natural.
New alert message would read
I'm not sure what it means that a hashing algorithm depends on data. So
for me, the original text below is much easier to understand.
Same goes for the other sensitive data queries.