make a shared library of the typo database #10357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Sep 8, 2022
ql/ql/src/qlpack.yml
Outdated
| @@ -5,3 +5,5 @@ dbscheme: ql.dbscheme | |||
| suites: codeql-suites | |||
| defaultSuiteFile: codeql-suites/ql-code-scanning.qls | |||
| extractor: ql | |||
| dependencies: | |||
| codeql/typos: "*" | |||
There was a problem hiding this comment.
For now, can you be explicit about the dependency here? This will require manually bumping when you change versions.
Suggested change
| codeql/typos: "*" | |
| codeql/typos: 0.0.1 |
We are working on something to make this simpler. See https://github.com/github/codeql-core/issues/2741
tausbn
approved these changes
Sep 9, 2022
aeisenberg
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo database was shared between JS and QL-for-QL.
With the new shared libraries we can avoid storing 2 copies of the same file.