Data flow: Guard against viableImplInCallContext not being a subset of viableCallable
#10505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/viable-impl-in-ctx-consistency
branch
4 times, most recently
from
b2b8aa6 to
27c9986
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
dataflow/viable-impl-in-ctx-consistency
branch
from
27c9986 to
167ad27
Compare
… of`viableCallable`
hvitved
force-pushed
the
dataflow/viable-impl-in-ctx-consistency
branch
from
167ad27 to
2334099
Compare
hvitved
force-pushed
the
dataflow/viable-impl-in-ctx-consistency
branch
from
2334099 to
914c711
Compare
tausbn
approved these changes
Sep 22, 2022
aschackmull
approved these changes
Sep 23, 2022
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 8b424d1
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 8b424d1
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 8b424d1
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 8b424d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a guard against, and consistency query for, cases where
callable = viableImplInCallContext(call, _)does not implycallable = viableCallable(call).As it turned out, this revealed a bug in the C# implementation, which is also fixed on this PR.