Skip to content

Java: Revert #10489 and #10640 #10671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

atorralba
Copy link
Contributor

@atorralba atorralba commented Oct 4, 2022

Reverts #10498, but keeps #10640.

The performance impact of getATypeInScope is too high (it produces a cartesian product of all CompilationUnits with all types in java.lang), we will need to reconsider this feature. @Marcono1234 let us know if you can think of an alternative.

aschackmull
aschackmull previously approved these changes Oct 4, 2022
@aschackmull
Copy link
Contributor

it produces a cartesian product of all CompilationUnits with all types in java.lang

And even without that disjunct, the predicate is still too big.

@atorralba atorralba merged commit d5478a0 into main Oct 4, 2022
@atorralba atorralba deleted the revert-10640-atorralba/fix-cartesian-product branch October 4, 2022 10:25
@Marcono1234
Copy link
Contributor

Should #4119 be reopened again?
(I can't do that because I did not close it)

@aschackmull
Copy link
Contributor

Should #4119 be reopened again?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants