Skip to content

Ruby: Remove PairValueContent #10686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 4, 2022

As pointed out by @asgerf, we no longer need PairValueContent, after SynthHashSplatArgumentNode was introduced (it was originally not there at the time when PairValueContent got introduced).

@github-actions github-actions bot added the Ruby label Oct 4, 2022
@hvitved hvitved marked this pull request as ready for review October 5, 2022 07:09
@hvitved hvitved requested a review from a team as a code owner October 5, 2022 07:09
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 5, 2022
@hvitved hvitved merged commit 1496c4f into github:main Oct 5, 2022
@hvitved hvitved deleted the ruby/remove-value-pair-content branch October 5, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants