Skip to content

Data flow: Take conjunctive With(out)Contents into account in prohibitsUseUseFlow #10691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2022
Merged

Data flow: Take conjunctive With(out)Contents into account in prohibitsUseUseFlow #10691

merged 5 commits into from
Oct 6, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 5, 2022 •
edited
Loading

Conjunctive With(out)Content models-as-data specifications such as

input = Argument[self].WithoutElement[0!].WithoutElement[1!] and
output = Argument[self]

did not work.

With this PR they do.

@hvitved hvitved force-pushed the dataflow/conjunctive-clears branch from 3b97a72 to 6f518c1 Compare October 5, 2022 10:58
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 5, 2022
@hvitved hvitved marked this pull request as ready for review October 5, 2022 11:14
@hvitved hvitved requested review from a team as code owners October 5, 2022 11:14
@hvitved hvitved mentioned this pull request Oct 5, 2022
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 5, 2022
View reviewed changes
@hvitved hvitved force-pushed the dataflow/conjunctive-clears branch from 5ba67f9 to 0beea9f Compare October 5, 2022 13:55
@hmac
Copy link
Contributor

hmac commented Oct 6, 2022

I've tested this on the flow summary I was trying to write and it works now 🎉

aschackmull
aschackmull approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared code LGTM.

@hvitved hvitved merged commit 0e6735b into github:main Oct 6, 2022
@hvitved hvitved deleted the dataflow/conjunctive-clears branch October 6, 2022 07:03
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10691
a8a9bcd 
Merge commit: 0e6735b
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10691
77b602c 
Merge commit: 0e6735b
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10691
34adec4 
Merge commit: 0e6735b
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10691
8957437 
Merge commit: 0e6735b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
C# DataFlow Library Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hvitved @hmac @aschackmull @owen-mc