Skip to content

Ruby: Fix SSA entry definitions for self in top-level #11206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2022
Merged

Ruby: Fix SSA entry definitions for self in top-level #11206

merged 1 commit into from
Nov 10, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 10, 2022

We were incorrectly generating two write definitions (at index 0 and 1 in the entry basic block); now we only generate one (at index 0).

@github-actions github-actions bot added the Ruby label Nov 10, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 10, 2022
@hvitved hvitved marked this pull request as ready for review November 10, 2022 14:46
@hvitved hvitved requested a review from a team as a code owner November 10, 2022 14:46
@hvitved hvitved merged commit bda4b52 into github:main Nov 10, 2022
@hvitved hvitved deleted the ruby/self-toplevel-def branch November 10, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aibaars