Swift: Add integral type classes

[MathiasVP]

I had these lying around as left-overs from some unrelated work, and they seem too useful to throw away (since most other languages have versions of these).

[geoffw0]

Thanks for finding and sharing this work. I think it needs a bit more polish before we merge it though, e.g. there really ought to be minimal test coverage. I know you have other priorities - let me know if you'd prefer me to do the changes to this PR?

[geoffw0]

Two things:

• isn't a floating point type numeric as well?
• other languages don't seem to include Bool as a numeric type.

[MathiasVP]

Good point. I agree with both of these observations 👍

[MathiasVP]

Thanks for finding and sharing this work. I think it needs a bit more polish before we merge it though, e.g. there really ought to be minimal test coverage. I know you have other priorities - let me know if you'd prefer me to do the changes to this PR?

Thanks! Yeah, I agree with all those comments. I'm not sure what the best testing approach to this would be. A naive thing would be a ql test that just selects all the relevant types from a large .swift file, but I fear that this will just be a .expected file that we just blindly accept test changes to.

I'd really appreciate if you could take over this PR 🙇.

[geoffw0]

No problem, I'll finish this PR probably this week.

[geoffw0]

I've made a PR onto this PR here: MathiasVP#5

@MathiasVP I suggest you review that and merge it (into this PR) when you're happy, then I'll merge this PR into main, hence everything will have had 2+ sets of eyes on it.

Any other reviewers, you're welcome to comment on there or here as well.

[geoffw0]

👍

I will do a follow-up to use the new classes in queries.

[geoffw0]

Checks failed - "Unable to connect to azure.archive.ubuntu.com" - sounds like we should retry in a few hours?

[MathiasVP]

Checks failed - "Unable to connect to azure.archive.ubuntu.com" - sounds like we should retry in a few hours?

Yeah. I already retried some other failing CI checks, and they seemed to succeed now. I'll just try restarting the final one right away.

[MathiasVP]

Bahh... Failed again 😭.