Skip to content

Swift: Add RNCryptor sinks to swift/constant-salt #11914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

Swift: Add RNCryptor sinks to swift/constant-salt #11914

merged 3 commits into from
Jan 25, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jan 17, 2023

Add RNCryptor sinks to swift/constant-salt. This PR is related to #11905 and #11911 .

I have also made NumberLiteral a source for this query, to support the very lazy (but all too plausible) initializer Data(0) used in some of the tests.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels Jan 17, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner January 17, 2023 18:12
MathiasVP
MathiasVP approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should probably run DCA on this. I'm always a bit hesitant with these flow-starting-at-all-constants queries since they will have a lot of sources, and so the initial forward phase of dataflow will have to do a lot of work.

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 25, 2023

I'm always a bit hesitant with these flow-starting-at-all-constants queries since they will have a lot of sources, and so the initial forward phase of dataflow will have to do a lot of work.

Ah, that's a good point. I'm not anticipating any new results on DCA for this change, but you make a good case I should run it anyway (and on similar PRs).

@geoffw0
Copy link
Contributor Author

geoffw0 commented Jan 25, 2023

DCA looks fine to me. Analysis is slightly slower but this is across a range of queries not just swift/constant-salt. Probably just wobble.

@geoffw0 geoffw0 merged commit f6fe627 into github:main Jan 25, 2023
@geoffw0 geoffw0 deleted the rncrypt3 branch March 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @MathiasVP