Skip to content

C# 11: String related functionality. #11922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 24, 2023
Merged

C# 11: String related functionality. #11922

merged 14 commits into from
Jan 24, 2023

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 18, 2023 •
edited
Loading

In this PR we

  • Make a small extractor change to fix the extracted value from an interpolated string.
  • Add tests for expressions that spans across multiple lines in a string interpolation expression.
  • Add tests for raw string literals (including combination tests with string interpolation).
  • Add Extractor support for UTF-8 encoded string literals (including tests).

@github-actions github-actions bot added the C# label Jan 18, 2023
@michaelnebel michaelnebel changed the title C#: Add test for interpolated strings, where newlines are used in the… C# 11: String related functionality. Jan 18, 2023
@michaelnebel michaelnebel marked this pull request as ready for review January 23, 2023 14:30
@michaelnebel michaelnebel requested a review from a team as a code owner January 23, 2023 14:30
tamasvajk
tamasvajk reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added two comments/questions.

@michaelnebel michaelnebel merged commit 4df615f into github:main Jan 24, 2023
@michaelnebel michaelnebel deleted the csharp11/strings branch January 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk tamasvajk approved these changes

Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @tamasvajk