Skip to content

Add missing toString case for synthetic globals #11941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add missing toString case for synthetic globals #11941

merged 1 commit into from
Jan 23, 2023

Conversation

alexrford
Copy link
Contributor

No description provided.

@alexrford alexrford marked this pull request as ready for review January 20, 2023 13:44
@alexrford alexrford requested review from a team as code owners January 20, 2023 13:44
@alexrford alexrford mentioned this pull request Jan 20, 2023
Merged
@alexrford alexrford added the no-change-note-required This PR does not need a change note label Jan 20, 2023
@alexrford alexrford changed the title Ruby: add missing toString case for synthetic globals Add missing toString case for synthetic globals Jan 20, 2023
aibaars
aibaars approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

michaelnebel
michaelnebel approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM!

@alexrford alexrford merged commit 55550e7 into github:main Jan 23, 2023
@alexrford alexrford deleted the summary-component-tostring-syntheticglobal branch January 23, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

@michaelnebel michaelnebel michaelnebel approved these changes

@aibaars aibaars aibaars approved these changes

@atorralba atorralba atorralba approved these changes

Assignees
No one assigned
Labels
C# DataFlow Library Go Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexrford @tausbn @michaelnebel @aibaars @atorralba