Skip to content

JS: Add support for TS 5.1 #12874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2023
Merged

JS: Add support for TS 5.1 #12874

merged 3 commits into from
Jun 6, 2023

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Apr 19, 2023

Mostly an uneventful upgrade.
The release notes mostly have things that are not relevant for us (better type inference, etc.).
But namespaced attributes in JSX is a new AST feature.

Still depends on an internal PR..
All tests pass locally.
Internal PR merged, everything green ✅


For the support for namespaced attributes JSX it might look weird that I just "forward" to the inner "name" attribute.
The reason is that which namespace it is doesn't seem important, and it's not part of the JSON object we get from the parser-wrapper.
Here is the full JSON from the parser-wrapper for one of the new attributes in the test: https://gist.github.com/erik-krogh/ec3989af630ba7e11c01ebf6f856ca80.
I could look into whether I can get the name of the namespace to be part of the output, but I don't see that as important.


Evaluation was uneventful.

@erik-krogh erik-krogh added the WIP This is a work-in-progress, do not merge yet! label Apr 19, 2023
@erik-krogh erik-krogh removed the WIP This is a work-in-progress, do not merge yet! label Jun 1, 2023
@erik-krogh erik-krogh marked this pull request as ready for review June 1, 2023 20:22
@erik-krogh erik-krogh requested a review from a team as a code owner June 1, 2023 20:22
@calumgrant calumgrant requested a review from asgerf June 6, 2023 08:23
@erik-krogh erik-krogh merged commit 0e6693b into github:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants