Skip to content

Go: Exclude all FlowSummaryNodes from test results #15341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

mbg
Copy link
Member

@mbg mbg commented Jan 16, 2024

This PR changes the LocalTaintStep and TaintStep integration tests to ignore FlowSummaryNodes in the results, which should mean that the results will be the same across different versions of Go so that we don't have to update the .expected files every time there is a new version of Go / these tests can succeed when using different Go versions.

Cherry-picked from #15202

@mbg mbg requested a review from a team as a code owner January 16, 2024 15:53
@github-actions github-actions bot added the Go label Jan 16, 2024
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looking forward to not having to update these test expectations in future.

@mbg mbg merged commit 5cf9bc2 into main Jan 17, 2024
@mbg mbg deleted the mbg/go/simplify-tests branch January 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants