Skip to content

JS: Add DataFlow::Node.getLocation #15882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2024
Merged

JS: Add DataFlow::Node.getLocation #15882

merged 2 commits into from
Mar 19, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 12, 2024 •
edited
Loading

In preparation for #15853.

The increase in extraction errors reported by DCA is because some @json_parse_error entities apparently have locations in hasLocation and not json_locations.

@github-actions github-actions bot added the JS label Mar 12, 2024
@hvitved hvitved force-pushed the js/dataflow-node-get-location branch from 7656b93 to 1d0e5d1 Compare March 12, 2024 10:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2024
View reviewed changes
javascript/ql/test/testUtilities/internal/InlineExpectationsTestImpl.qll
string getContents() { result = this.getText() }

/** Gets this element's location. */
Location getLocation() { result = super.getLocation() }

Check warning

Code scanning / CodeQL

Missing override annotation

ExpectationComment.getLocation overrides [Comment.getLocation](1) but does not have an override annotation.
@hvitved hvitved force-pushed the js/dataflow-node-get-location branch 5 times, most recently from 5a0db29 to 1b249e9 Compare March 13, 2024 09:56
@hvitved hvitved force-pushed the js/dataflow-node-get-location branch from 1b249e9 to 16cef92 Compare March 13, 2024 12:06
@hvitved hvitved mentioned this pull request Mar 13, 2024
Merged
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Mar 13, 2024
@hvitved hvitved marked this pull request as ready for review March 13, 2024 14:33
@hvitved hvitved requested a review from a team as a code owner March 13, 2024 14:33
asgerf
asgerf approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 👍

@hvitved hvitved merged commit 5ab1047 into github:main Mar 19, 2024
@hvitved hvitved deleted the js/dataflow-node-get-location branch March 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @asgerf