Skip to content

Swift: accept new test results #16197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Swift: accept new test results #16197

merged 1 commit into from
Apr 12, 2024

Conversation

redsun82
Copy link
Contributor

No idea why this test started failing on main, but the diff seems harmless.

@redsun82 redsun82 requested a review from geoffw0 April 12, 2024 12:59
@redsun82 redsun82 requested a review from a team as a code owner April 12, 2024 12:59
@github-actions github-actions bot added the Swift label Apr 12, 2024
@MathiasVP
Copy link
Contributor

The changes come from #15501. Those added edges and nodes do appear to be duplications, so if CI is happy then this LGTM!

@geoffw0
Copy link
Contributor

geoffw0 commented Apr 12, 2024

Thanks for finding that link @MathiasVP - I was looking for it too. In short, the provenance stuff is new, I agree the diff seems harmless, I'm slightly confused as to how it happened and whether there might be another change that's supposed to have been merged or something.

@redsun82 redsun82 merged commit 6794661 into main Apr 12, 2024
16 checks passed
@redsun82 redsun82 deleted the redsun82/accept-swift-tests branch April 12, 2024 13:34
redsun82 added a commit that referenced this pull request Apr 12, 2024
@redsun82
Swift: add shared/** to CI triggers
de4ffbb 
Not being triggered by changes in shared was making it possible to not
notice changes in `shared` having effect on Swift tests. For example
[this PR](#15501) introduced a
test change that was fixed [here](#16197).
@redsun82 redsun82 mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redsun82 @MathiasVP @geoffw0