Skip to content

JS: Improve support for export * as ... declarations #16241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Apr 17, 2024

We didn't properly support this in API graphs:

export * as foo from "./bar"

When we can resolve ./bar to a module, we now generate store steps into the * as foo specifier, and mark * as foo as the export named foo in the current module.

This also led to some general improvements to API graphs since it's quite convenient if API graphs generally converts load/store to member steps (something similar is already happening in Ruby).

@github-actions github-actions bot added the JS label Apr 17, 2024
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Apr 18, 2024
@asgerf asgerf marked this pull request as ready for review April 18, 2024 13:24
@asgerf asgerf requested a review from a team as a code owner April 18, 2024 13:24
@asgerf asgerf merged commit ac34b92 into github:main Apr 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants