C#: Refactor extractor state classes and simplify extraction code #16732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+194
to
+197
| catch (Exception e) | ||
| { | ||
| ExtractionContext.Logger.LogDebug($"Failed to compute absolute path for relative path in line mapping: '{mappedToPath}': {e}"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
Comment on lines
+152
to
+155
| catch (Exception ex) // lgtm[cs/catch-of-all-exceptions] | ||
| { | ||
| fileLogger.Log(Severity.Error, " Unhandled exception: {0}", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
michaelnebel
previously approved these changes
Jun 12, 2024
| { | ||
| Extractor = extractor; | ||
| ExtractionContext = extractor; |
There was a problem hiding this comment.
nit: rename parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves changes to the
Semmle.Extraction.CSharpproject to improve the handling of extraction context. The changes include using a newExtractionContextobject instead of the previousExtractorobject, adding new properties to theAnalyserclass, and updating method parameters and calls to use the new context. The changes aim to enhance the maintainability and readability of the codebase.