Skip to content

C++: Promote cpp/unsafe-strncat to Code Scanning #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2024
Merged

C++: Promote cpp/unsafe-strncat to Code Scanning #16930

merged 2 commits into from
Jul 8, 2024

Conversation

MathiasVP
Copy link
Contributor

The query produces excellent results on MRVA 🎉 (see the backlink for analysis of the results).

@MathiasVP MathiasVP requested a review from a team as a code owner July 8, 2024 15:03
@github-actions github-actions bot added the C++ label Jul 8, 2024
geoffw0
geoffw0 reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I wrote something but it was intended for a different discussion...)

geoffw0
geoffw0 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, results LGTM. 👍

@MathiasVP MathiasVP merged commit 39ad4d4 into github:main Jul 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @geoffw0