C#: Order syntax trees before creating compilation #16968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
approved these changes
Jul 12, 2024
hvitved
reviewed
Jul 12, 2024
| @@ -435,6 +435,8 @@ public static IEnumerable<Action> ReadSyntaxTrees(IEnumerable<string> sources, A | |||
| } | |||
| } | |||
|
|
|||
| syntaxTrees.Sort((a, b) => string.Compare(a.FilePath, b.FilePath, StringComparison.Ordinal)); | |||
There was a problem hiding this comment.
Should we instead respect the order in which the files were passed to the compiler in traced/binlog mode?
There was a problem hiding this comment.
The binlog extractor is not impacted by this change, because that uses the compilation from the complog API.
For traced extraction it would probably be better to use the order from the arguments, but I'd rather merge this PR and see if it solves our non-determinism issues, and do a follow up PR later. We're anyways using a random order currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reverting the changes in #16945 and instead orders syntax trees before creating the compilation. I overlooked the fact that we're creating syntax trees on multiple threads, so ordering the files didn't result in a stable order for the syntax trees. This PR fixes that by ordering the syntax trees directly.
This change has an impact on both traced and buildless extraction.