Skip to content

C++: Strip specifiers and typedefs when finding iterator parameter for string taint function #16969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2024
Merged

C++: Strip specifiers and typedefs when finding iterator parameter for string taint function #16969

merged 2 commits into from
Jul 12, 2024

Conversation

MathiasVP
Copy link
Contributor

No description provided.

@MathiasVP MathiasVP requested a review from a team as a code owner July 12, 2024 08:55
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Jul 12, 2024
@github-actions github-actions bot added the C++ label Jul 12, 2024
@MathiasVP MathiasVP requested a review from jketema July 12, 2024 08:56
jketema
jketema previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM is DCA is happy.

@MathiasVP
Copy link
Contributor Author

MathiasVP commented Jul 12, 2024 •
edited
Loading

Apparently, Coding Standards depends on iterators sometimes not being stripped of specifiers and typedefs. So I've made the code slightly more robust in 84c83f4. Hopefully that unbreaks Coding Standards 🤞 Scratch that. Coding Standards is still broken. I'll update their tests

jketema
jketema previously approved these changes Jul 12, 2024
View reviewed changes
@MathiasVP MathiasVP force-pushed the add-missing-underlying-type branch from 84c83f4 to 7a2b170 Compare July 12, 2024 10:02
@MathiasVP MathiasVP mentioned this pull request Jul 12, 2024
Merged
30 tasks
@MathiasVP
Copy link
Contributor Author

DCA was uneventful 🎉

@MathiasVP MathiasVP merged commit f6627cc into github:main Jul 12, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema jketema approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @jketema