Skip to content

Java: add TaintInheritingContent for URL synthetic fields #17025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Jul 21, 2024

#16062 added synthetic fields to certain URL models, but did not ensure that a generally-tainted URL also taints its synthetic fields, which caused some lost flow. This PR ensures that the synthetic fields of a URL are tainted and adds a couple test cases for this scenario.

@github-actions github-actions bot added the Java label Jul 21, 2024
@jcogs33 jcogs33 marked this pull request as ready for review July 24, 2024 20:25
@jcogs33 jcogs33 requested a review from a team as a code owner July 24, 2024 20:25
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcogs33 jcogs33 merged commit 91f5f08 into github:main Jul 25, 2024
19 checks passed
@jcogs33 jcogs33 deleted the jcogs33/java/adjust-url-syntheticfield branch July 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants