Skip to content

Java: Reveal false negative in test #17274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Aug 21, 2024

One of the sinks in ImplicitPendingIntents was flagged for the wrong reason in the test case.

The flow into the startActivities sink isn't working properly, but this was not revealed by the test since an alternate, spurious path exists. The spurious path goes through the implicit read at the prior sink and takes a use-use step to the startActivities sink. Swapping the order of the two sinks reveals the false negative.

I noticed this while attempting to fix the above-mentioned issue where a use-use step is taken after an implicit read, which caused this test to fail. But for now, just updating the test to reveal the missed flow.

asgerf added 3 commits August 21, 2024 13:36
One of the sinks was flagged for the wrong reason in the test case.

The flow into the 'startActivities' sink isn't working properly, but this was not revealed by the test since an alternate, spurious path exists. The spurious path goes through the implicit read at the prior sink and takes a use-use step to the 'startActivities' sink. Swapping the order of the two sinks reveals the false negative.
@github-actions github-actions bot added the Java label Aug 21, 2024
@asgerf asgerf marked this pull request as ready for review August 22, 2024 08:55
@asgerf asgerf requested a review from a team as a code owner August 22, 2024 08:55
@asgerf asgerf merged commit 43f54db into github:main Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants