Skip to content

C#: Change reporting location of partial methods #17276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2024
Merged

C#: Change reporting location of partial methods #17276

merged 2 commits into from
Aug 22, 2024

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C# label Aug 21, 2024
@tamasvajk tamasvajk marked this pull request as ready for review August 21, 2024 13:58
@tamasvajk tamasvajk requested a review from a team as a code owner August 21, 2024 13:58
hvitved
hvitved approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Let's do a DCA run before merging.

@tamasvajk
Copy link
Contributor Author

The DCA experiment shows changes in dotnet__runtime for a couple of queries. Some of these queries (cs/useless-cast-to-self, cs/non-short-circuit, cs/dispose-not-called-on-throw) are matching the ones that I investigated lately with nightly wobbles, so hopefully after this PR is merged, the wobbles are gone.

@tamasvajk tamasvajk merged commit 3dce56b into github:main Aug 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved