Skip to content

TreeSitter extractors: log fewer lines #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

TreeSitter extractors: log fewer lines #18713

merged 1 commit into from
Feb 11, 2025

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Feb 7, 2025

Printing a line for every extracted file is too verbose and for large projects makes it impossible to view the log in the Actions UI.

@aibaars
TreeSitter extractors: log fewer lines
a8fbb37 
Printing a line for every extracted file is too verbose and for large projects makes it impossible to view the log in the Actions UI.
@Copilot Copilot AI review requested due to automatic review settings February 7, 2025 11:28
Copilot
Copilot AI reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

hvitved
hvitved approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the line still be added to the extractor log?

@aibaars
Copy link
Contributor Author

aibaars commented Feb 7, 2025

Will the line still be added to the extractor log?

I don't think so, unless the log writer uses a higher log level. The line should still be added when a workflow is re-run in debug mode.

@aibaars aibaars merged commit 7e569b4 into main Feb 11, 2025
41 checks passed
@aibaars aibaars deleted the aibaars-patch-2 branch February 11, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @hvitved