Skip to content

JS: fix an off-by-one error in the AngularJS expression AST #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 8, 2018
Merged

JS: fix an off-by-one error in the AngularJS expression AST #29

merged 1 commit into from Aug 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2018

This PR make NgsingleFilter:getArgument use a zero-offset for its arguments.
This PR also adds two tests to prevent related regressions.

Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiemaisi xiemaisi added the JS label Aug 8, 2018
@xiemaisi xiemaisi merged commit 355302e into github:master Aug 8, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Deduplicate and sort union members
smowton pushed a commit to smowton/codeql that referenced this pull request Oct 28, 2021
Handle type parameters which are nullable without question mark
erik-krogh added a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
add `ql/override-parameter-name`
erik-krogh added a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
dbartol pushed a commit that referenced this pull request Dec 18, 2024
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant