JavaScript: Add modelling of AMD imports. #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon rerunning, the >= 5% slowdowns were not reproducible, so on the whole this PR does not seem to affect performance measurably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already modelled exports, but for some reason not imports.
Evaluation report here (internal link), one new result that looks like a TP. The slowdowns on a few projects look disappointing; in fact, it looked even worse at first, so I reran a few outliers, which caused the slowdown to disappear, suggesting that it was probably a fluke. My guess is that this is true for the remaining slowdowns as well (in particular since they are all fairly small projects). I'd be happy to rerun a few more to confirm if desired.