C++: Deprecate queries using VCS.qll #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One query imported VCS.qll for no reason, so I removed the import instead of deprecating the query.
|
Do we want a comment explaining the deprecation for queries, like we do with classes and predicates? What's the history of |
|
Thanks @jbj! @geoffw0: see https://jira.semmle.com/browse/ODASA-7486 for more detailed discussion. It's not used on LGTM. |
|
Sorry, I should have linked to the Jira issue from here. |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…nder-codeql Tolerate empty-string CODEQL_PLATFORM, and add smoke tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the files I could find with
git grep 'import.*VCS'.One query imported VCS.qll for no reason, so I removed the import instead of deprecating the query.