TS: cache type IDs on type objects #594
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up full-mode extraction by caching the ID of a type on TypeScript type object, and checking the expansiveness cache a bit earlier. Type objects do not survive across different compiler instances, so the cache really is temporary and is not a replacement for any of the
Map
instances stored on the type table.The benchmark for #479 showed TypeScript to be an outlier, in that full-mode had a 10X overhead on TypeScript, whereas other projects are closer to 2X. The larger impact on TypeScript is expected as a larger fraction of its time is spent extracting types.