C#: Sync samples and qltest cases #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
requested changes
Dec 12, 2018
| @@ -1,18 +1,15 @@ | |||
| using System; | |||
|
|
|||
| namespace NullMaybe | |||
| class Bad | |||
There was a problem hiding this comment.
I think we actually want to sync the other way around, i.e., copy the files from the tests to the samples. That way the test files for NullMaybe and NullAlways will follow the same structure (having a namespace).
There was a problem hiding this comment.
All of the samples I've been browsing don't have a namespace, which I would agree with because it's good to keep them as short as possible.
hvitved
approved these changes
Dec 12, 2018
Closed
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Refactor `ReturnValue[n]` in data flow libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync up the -Good and -Bad files introduced in #593. This caused a PR-check failure.