Skip to content

Remove security-severity tag to java/random-used-once #7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Remove security-severity tag to java/random-used-once #7613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16aa53a
Add security tag to java/random-used-once
smowton Jan 17, 2022
f0645a3
Remove security-severity tag instead
smowton Jan 19, 2022
c63fcb2
Add change note
smowton Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java/ql/src/Likely Bugs/Arithmetic/RandomUsedOnce.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* guarantee an evenly distributed sequence of random numbers.
* @kind problem
* @problem.severity warning
* @security-severity 9.8
* @precision medium
* @id java/random-used-once
* @tags reliability
Expand Down
4 changes: 4 additions & 0 deletions java/ql/src/change-notes/2022-01-19-random-used-once.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: queryMetadata
---
* The "Random used only once" (`java/random-used-once`) query no longer has a `security-severity` score. This has been causing some tools to categorise it as a security query, when it is more useful as a code-quality query.