JS: add a js/samesite-none-cookie cookie #7721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
force-pushed
the
CWE-1275
branch
3 times, most recently
from
bfe2ac0 to
f52d32a
Compare
erik-krogh
removed
the
Awaiting evaluation
esbena
reviewed
Jan 25, 2022
| @@ -132,6 +148,10 @@ private module JsCookie { | |||
| } | |||
|
|
|||
| override predicate isSensitive() { canHaveSensitiveCookie(this.getArgument(0)) } | |||
|
|
|||
| override string getSameSite() { | |||
| this.getOptionArgument(2, "sameSite").mayHaveStringValue(result) | |||
There was a problem hiding this comment.
Should we introduce a shared (inline) predicate for this string/bool -> string conversion? I list the suggestion here because I do not see the harm in adding it for this smaller predicate as well.
esbena
added
the
ready-for-doc-review
mchammer01
previously approved these changes
Jan 25, 2022
There was a problem hiding this comment.
@erik-krogh - LGTM from an editorial point of view ✨
Made a few minor suggestions.
Co-authored-by: mc <[email protected]>
mchammer01
approved these changes
Jan 25, 2022
esbena
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDN Web Docs: SameSite.
I've set the
@precisiontomedium, becauseSameSite=Noneis only an issue if there isn't any other CSRF protection.And the query makes no attempt to detect the existence of CSRF protection.
The default value for
SameSiteisLax.The
Laxsetting is not great, but also not terrible, so I don't want to flag that.(Also: The
SameSiteattribute is somewhat recent. E.g. there is no IE version that supports it).Evaluation shows no new results, and a constant slow-down caused by having to compile the new query.
/cc @esbena: This is at least the second time I've seen an evaluation where a new query is compiled by
codeql-action/analyzebecause it didn't hit anything in the cache.