-
Notifications
You must be signed in to change notification settings - Fork 1.7k
TypeScript: support TypeScript 3.0 features #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiemaisi
previously approved these changes
Aug 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The typo fix can be done separately to avoid complicating the merge.
* An optional type element in a tuple type, such as `number?` in `[string, number?]`. | ||
*/ | ||
class OptionalTypeExpr extends @optionaltypeexpr, TypeExpr { | ||
/** Gets the type `T` in `T?` */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing full stop.
950b383
to
13d8a46
Compare
69e8f3d
to
35aa2e6
Compare
xiemaisi
approved these changes
Aug 22, 2018
Extractor PR has been merged. |
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Updates after CodeQL upgrade to 2.4.1
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Extract type aliases
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
Refactor Call.getTarget to be an AstNode
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
…stnode Refactor Call.getTarget to be an AstNode
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Add models for list-files actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for new features in TypeScript 3.0, in the AST and type system:
unknown
type[number, string?]
[number, ...string[]]
Should land in tandem with extractor changes.