Skip to content

C++: Fix the join order in the IR dataflow library #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Mar 2, 2022

Not having this fixed caused problems when updating the database stats file.

@github-actions github-actions bot added the C++ label Mar 2, 2022
@jketema jketema force-pushed the taint-join-order branch from ad2c383 to e688885 Compare March 2, 2022 18:29
@jketema jketema changed the title C++: Fix the join order in two places in the IR dataflow library C++: Fix the join order in in the IR dataflow library Mar 2, 2022
@jketema jketema added the no-change-note-required This PR does not need a change note label Mar 2, 2022
@jketema jketema marked this pull request as ready for review March 2, 2022 20:22
@jketema jketema requested a review from a team as a code owner March 2, 2022 20:22
MathiasVP
MathiasVP previously approved these changes Mar 2, 2022
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema changed the title C++: Fix the join order in in the IR dataflow library C++: Fix the join order in the IR dataflow library Mar 2, 2022
Not having this fixed caused problems when updating the database
scheme stats file.
@jketema
Copy link
Contributor Author

jketema commented Mar 3, 2022

@MathiasVP I fixed a typo in the commit message that was annoying me, otherwise no changes.

@jketema jketema merged commit 3fc2f2f into github:main Mar 3, 2022
@jketema jketema deleted the taint-join-order branch March 3, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants