Skip to content

Enforcing consistent casing of acronyms #8323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 14, 2022
Merged

Enforcing consistent casing of acronyms #8323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e3a1579
QL: add query detecting upper-case acronyms
erik-krogh Mar 3, 2022
69353bb
patch upper-case acronyms to be PascalCase
erik-krogh Mar 11, 2022
23191b1
C#: rename XmlComment to XmlCommentLine to avoid naming conflict
erik-krogh Mar 3, 2022
ed54d7b
fixup getAPrimaryQlClass
erik-krogh Mar 3, 2022
b568bb9
JS: remove duplicated predicate
erik-krogh Mar 3, 2022
cc43a94
Java: remove duplicated class
erik-krogh Mar 3, 2022
bb32c79
Java: add missing qldoc
erik-krogh Mar 3, 2022
2569075
JS: update expected test output
erik-krogh Mar 4, 2022
8f08b4c
JS: add missing QLDoc
erik-krogh Mar 11, 2022
c2787ee
RB: add missing QLDoc
erik-krogh Mar 11, 2022
1a275a3
add change-notes
erik-krogh Mar 7, 2022
4f8f7cd
JS: update expected output of test
erik-krogh Mar 7, 2022
b63b675
RB: add explicit-this
erik-krogh Mar 11, 2022
a5a82a0
JS: remove accidential copy-pasted change-note
erik-krogh Mar 11, 2022
2e29701
fix typo in change-note
erik-krogh Mar 11, 2022
1e36561
fix all other implicit-this warnings introduced by the acronym patch
erik-krogh Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions cpp/ql/lib/change-notes/2022-02-07-deprecated-acronyms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: deprecated
---
* Many classes/predicates/modules that had upper-case acronyms have been renamed to follow our style-guide.
The old name still exists as a deprecated alias.
4 changes: 2 additions & 2 deletions cpp/ql/lib/semmle/code/cpp/Print.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ private import PrintAST
private predicate shouldPrintDeclaration(Declaration decl) {
not decl instanceof Function
or
not exists(PrintASTConfiguration c)
not exists(PrintAstConfiguration c)
or
exists(PrintASTConfiguration config | config.shouldPrintFunction(decl))
exists(PrintAstConfiguration config | config.shouldPrintFunction(decl))
}

/**
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/PrintAST.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import PrintAST
* Temporarily tweak this class or make a copy to control which functions are
* printed.
*/
class Cfg extends PrintASTConfiguration {
class Cfg extends PrintAstConfiguration {
/**
* TWEAK THIS PREDICATE AS NEEDED.
* Holds if the AST for `func` should be printed.
Expand Down
Loading