QL: add query detecting block comments in a position where a QLDoc should be #8374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
nonDocBlock
branch
3 times, most recently
from
3836389 to
3eee48c
Compare
MathiasVP
approved these changes
Mar 11, 2022
tausbn
approved these changes
Mar 11, 2022
geoffw0
reviewed
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this block comment that should have been a QLDoc.
That comment not being a QLDoc caused my "remove all deprecated things and their QLDoc"-patch to not delete that comment.
There appears to be some results, mostly in Python. (The results I haven't fixed look benign).