Rename all upper-case variables, and all lower-case modules #8403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
reviewed
Mar 14, 2022
nickrolfe
requested changes
Mar 14, 2022
javascript/ql/lib/change-notes/2022-02-07-deprecated-modules.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Rolfe <[email protected]>
jbj
approved these changes
Mar 14, 2022
RasmusWL
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Looks ok for Python.
A bit unfortunate that there was not consistency between the renaming, and we got DjangoImpl, InvokeModule, and DjangoMod, but as I said in inline comment, that's sort of a nitpick, and it's for code that we want to rewrite anyway, so meh 🤷
| @@ -20,14 +20,14 @@ private module Invoke { | |||
| API::Node invoke() { result = API::moduleImport("invoke") } | |||
|
|
|||
| /** Provides models for the `invoke` module. */ | |||
| module invoke { | |||
| module InvokeModule { | |||
There was a problem hiding this comment.
NIT: Would have been nice with consistency between what it was called for django (DjangoImpl) and here. But 🤷 since this is something we want to rewrite anyway.
There was a problem hiding this comment.
I'll change it if I get a change request from JS, otherwise I'll just keep it.
nickrolfe
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Wait for #8323.Adds a QL-for-QL queries that puts every name definitions in two categories:
Every violation of the above is fixed as part of this PR, luckily almost no code violated the above.
A few modules in the public API started with a lower-case letter, I've left a deprecated alias for those.
/cc @jbj