Skip to content

C++: Add additional command line injection tests #8483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

C++: Add additional command line injection tests #8483

merged 2 commits into from
Mar 18, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Mar 18, 2022 •
edited
Loading

One additional test involving branching and one additional test involving strncat in a called subroutine.

@jketema jketema requested a review from a team as a code owner March 18, 2022 12:46
@github-actions github-actions bot added the C++ label Mar 18, 2022
@jketema jketema requested a review from rdmarsh2 March 18, 2022 12:47
rdmarsh2
rdmarsh2 previously approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd like to see the TODO resolved but that doesn't need to block a merge

@jketema jketema requested a review from rdmarsh2 March 18, 2022 15:13
@rdmarsh2 rdmarsh2 merged commit 4bf35ad into github:main Mar 18, 2022
@jketema jketema deleted the command-line-injection-test-cases-with-calls branch March 18, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmarsh2 rdmarsh2 rdmarsh2 approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @rdmarsh2