JS: make string formatting a taint step #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
xiemaisi
suggested changes
Aug 21, 2018
| abstract DataFlow::Node getFormatString(); | ||
|
|
||
| /** | ||
| * Gets the i'th argument to the format string. |
There was a problem hiding this comment.
|
Amended. |
xiemaisi
approved these changes
Aug 21, 2018
|
Needs conflict resolution (the web interface actually works reasonably well). |
|
Resolved. |
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Add support for companion objects
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Improve reusable workflow calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds string formatting, like
util.format('echo "%s"', x), as a default taint step.There are no new results on the standard benchmarks, but performance is at least unchanged.