JS: filter away reads of .src that end in a URL sink for js/xss-through-dom #8509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
reviewed
Mar 22, 2022
| } | ||
|
|
||
| /* Gets a jQuery method where the receiver looks like a $("<p>" + ... ), which is benign for this query. */ | ||
| private JQuery::MethodCall benignJQueryMethod() { |
There was a problem hiding this comment.
Backticks around the $("<p>" + ...) code snippet.
erik-krogh
commented
Mar 22, 2022
javascript/ql/lib/semmle/javascript/security/dataflow/XssThroughDomCustomizations.qll
Outdated
Show resolved
Hide resolved
asgerf
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #8304, this is a first try to reduce the FP amount for
js/xss-through-dom.The evaluation removes a bunch of pretty benign
var s = x.src ... y.src = sflows as expected, and shows no real performance difference.