Skip to content

C#: Minor CFG improvements #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2018

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 23, 2018

Added a comment to startsSplits() (see #76 (comment)), and made a small performance improvement to throwMayBeUncaught().

…les()`

The `definitelyHandles()` predicate calculates the relation for all exception
types, not just the ones that can actually be thrown (no automatic magic).
This commit inlines the definition of `definitelyHandles()` to get the proper
context (manual magic).
@hvitved hvitved added the C# label Aug 23, 2018
@hvitved hvitved requested a review from calumgrant August 23, 2018 12:42
@hvitved hvitved requested a review from a team as a code owner August 23, 2018 12:42
@hvitved hvitved added this to the 1.18 milestone Aug 31, 2018
@xiemaisi
Copy link

xiemaisi commented Sep 3, 2018

This PR is tagged for 1.18 but targeted at master, not rc/1.18.

@hvitved hvitved changed the base branch from master to rc/1.18 September 3, 2018 07:27
@calumgrant calumgrant merged commit af3f855 into github:rc/1.18 Sep 3, 2018
@hvitved hvitved deleted the csharp/cfg/minor-fixes branch September 3, 2018 18:59
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
Kotlin: Add uses of listOf to the tests, and fix the extractor to produce consistent databases for them
dbartol pushed a commit that referenced this pull request Dec 18, 2024
Fix: ControlChecks protects/dominates only work with Steps. A sink can be in a sub-step node (eg: ScalarValue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants